Skip to content

Conversation

@VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Jan 19, 2026

Description

Aligns the frontend's k6 channel data structure with the new backend API specification. The channel information is now stored at the root level (channels.k6) instead of nested within check type settings. See https://github.com/grafana/synthetic-monitoring/issues/408#issuecomment-3595507029 for its definition and discussion.

Backend Context

The backend API now expects/returns channel data in this format:

Request (create/update check):

{
  "channels": {
    "k6": {
      "id": "v1"
    }
  }
}

Response (fetching checks):

{
  "channels": {
    "k6": {
      "id": "v1",
      "name": "v1.x",
      "default": true,
      "manifest": "^1.0.0",
      "deprecatedAfter": "2027-06-01T00:00:00Z"
    }
  }
}

Related backend PR: https://github.com/grafana/synthetic-monitoring-api/pull/1876

@VikaCep VikaCep self-assigned this Jan 19, 2026
@github-actions github-actions bot added the fix A fix applied to the application. label Jan 19, 2026
@github-actions
Copy link

github-actions bot commented Jan 19, 2026

Script size changes

Name +/- Main This PR Outcome
[263.js] +4.24% 1,646.45 kB 1,716.20 kB
[234.js] New file - 804.37 kB
[datasource/module.js] -0.16% 24.56 kB 24.52 kB
[692.js] -3.66% 20.57 kB 19.82 kB
[663.js] = 5.84 kB 5.84 kB
[module.js] +0.08% 4.85 kB 4.86 kB
[88.js] Deleted file 984.46 kB -

Totals

Name +/- Main This PR Outcome
[Scripts] -4.14% 2,686.74 kB 2,575.61 kB
[Non-script Assets] +0.02% 2,671.09 kB 2,671.65 kB
[All] -2.06% 5,357.82 kB 5,247.26 kB

Generated by 🚫 dangerJS against 2ca38a4

@VikaCep VikaCep force-pushed the fix/vm-check-channel branch from d2420ad to 1e8475e Compare January 21, 2026 17:42
@VikaCep VikaCep marked this pull request as ready for review January 21, 2026 17:48
@VikaCep VikaCep requested a review from a team as a code owner January 21, 2026 17:48
@VikaCep VikaCep requested review from ckbedwell and w1kman and removed request for a team January 21, 2026 17:48
ckbedwell
ckbedwell previously approved these changes Jan 22, 2026
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I much prefer this to the previous schema.

@VikaCep VikaCep merged commit 55a6d48 into main Jan 22, 2026
55 of 63 checks passed
@VikaCep VikaCep deleted the fix/vm-check-channel branch January 22, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix applied to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants