chore: provide React 19 support #1551
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated push.yml from v4.3.0 to v6.0.0 - Updated publish.yml from v4.3.0 to v6.0.0 - Set run-playwright: true to test behavior without Playwright tests - v6.0.0 adds React 19 testing support to E2E matrix Testing in draft PR to determine if Playwright is needed for React 19 compatibility. Ran @grafana/react-detect - found 0 issues in our code, only upstream dependencies.
Required breaking change for plugin-ci-workflows v6.0.0. Without this permission, the cd workflow job won't run.
Reusable workflows need permissions at top level, not job level. This was preventing the workflow from being callable.
github-actions
bot
added
the
chore
Script size changes
Totals
|
Both call_grafana-compat.yml and call_renovate_reviewer.yml had permissions at job level instead of workflow level, which is required for workflow_call. This prevents 'workflow was not found' errors in v6.0.0.
VikaCep
changed the title
VikaCep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Takes recommended actions to make the app compatible with Grafana 13's React 19 migration.
Closes #1544
Changes Made
Workflow Updates:
.github/workflows/push.ymland.github/workflows/publish.ymlto v6.0.0call_grafana-compat.yml- Moved permissions to top levelcall_renovate_reviewer.yml- Moved permissions to top levelReact 19 Compatibility Fixes
react/jsx-runtimein webpack config (prevents__SECRET_INTERNALScrashes)grafanaDependencyto>=12.3.0(required for jsx-runtime externalization, otherwise it breaks)See https://docs.google.com/document/d/1ZBWYTkZQ_ra0oS050Wor11YM7PPQ82fV0n2NB6dGj1o/edit?tab=t.0#heading=h.8xoyr4y4o2pu for more info on this.
React 19 Compatibility Scan
Ran
@grafana/react-detecttool per Grafana's React 19 guidance:✅ Our Code: Clean
0 issues found - Our codebase is React 19 ready.
findDOMNodedefaultProps/PropTypesℹ️ False Positives: 2 (No Action Needed)
ReactDOM.renderReactDOM.renderflushSync(React 19 compatible)Validation
✅ Tested with React 19 Preview
Validated plugin functionality using Grafana's React 19 developer preview:
Results: