chore(deps) replace go-test/deep with google/go-cmp#7296
Merged
Conversation
stoewer
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
yvrhdn,
zalegrala and
zhxiaogg
as code owners
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the github.com/go-test/deep dependency with github.com/google/go-cmp/cmp for trace comparison diffs in tempo-vulture, removing the vendored go-test/deep module to reduce the dependency surface area (part of dependency cleanup work in #7218).
Changes:
- Drop
github.com/go-test/deepfromgo.mod,go.sum, andvendor/, and remove its vendored sources. - Switch
tempo-vulturemismatch diff reporting fromdeep.Equal(...)tocmp.Diff(...)in both runtime logging and the fixture test. - Update
vendor/modules.txtaccordingly.
Reviewed changes
Copilot reviewed 3 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Removes the direct requirement on github.com/go-test/deep. |
go.sum |
Removes checksums for github.com/go-test/deep. |
vendor/modules.txt |
Removes the vendored module entry for github.com/go-test/deep. |
cmd/tempo-vulture/main.go |
Replaces per-diff logging from deep.Equal with a single cmp.Diff string. |
cmd/tempo-vulture/main_test.go |
Replaces fixture diff reporting from deep.Equal with cmp.Diff. |
vendor/github.com/go-test/deep/deep.go |
Removed vendored go-test/deep implementation. |
vendor/github.com/go-test/deep/README.md |
Removed vendored documentation. |
vendor/github.com/go-test/deep/SECURITY.md |
Removed vendored security policy doc. |
vendor/github.com/go-test/deep/LICENSE |
Removed vendored license file. |
vendor/github.com/go-test/deep/CHANGES.md |
Removed vendored changelog. |
vendor/github.com/go-test/deep/.gitignore |
Removed vendored ignore file. |
electron0zero
previously approved these changes
May 29, 2026
…test-deep # Conflicts: # go.mod # vendor/modules.txt
electron0zero
approved these changes
Jun 9, 2026
oleg-kozlyuk-grafana
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Replace go-test/deep with google/go-cmp
Which issue(s) this PR fixes:
Contributes to #7218
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]