Skip to content

Use events to open traces #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adrapereira
Copy link
Collaborator

@adrapereira adrapereira commented Apr 10, 2025

Fixes issue where the primary signal would become unselected when opening a trace.

Fixes #406

Copy link
Collaborator

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a shared openTrace method please? I would prefer for debugging / maintainability purposes if all EventTraceOpened events are routed through the same method.

@adrapereira adrapereira merged commit c4ed245 into main Apr 11, 2025
4 checks passed
@adrapereira adrapereira deleted the andre/remove-locationservice-usage-when-opening-traces branch April 11, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query error when viewing all spans and opening a trace
2 participants