Skip to content

Fix CI #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2017
Merged

Fix CI #471

merged 2 commits into from
May 24, 2017

Conversation

benjie
Copy link
Member

@benjie benjie commented May 23, 2017

No description provided.

benjie added 2 commits May 23, 2017 12:14
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

microsoft/TypeScript#14628
@benjie benjie requested a review from ferdinandsalis May 23, 2017 11:26
@sandersn
Copy link

@benjie if you know what changed recently in the dependencies of postgraphql, can you open a bug on Microsoft/TypeScript? The fix to tsconfig indicates that one of the JS libraries that postgraphql depends on caused the Typescript compiler to crash.

@benjie
Copy link
Member Author

benjie commented May 23, 2017

@sandersn I think it's microsoft/TypeScript#14628 as noted in ebf68c8 - at least that's where I got the solution from (i.e. using include). I'm not sure what changed - we didn't change the dependencies so it must have been a semver-incompatible change in one of our dependencies.

@sandersn
Copy link

Yep, microsoft/TypeScript#14628 was how I got here. Big Javascript packages tend to expose new scale bugs in the compiler, so I thought I'd check whether you had a suspect for which dependency changed so I could investigate that package. No worries if not.

@sandersn
Copy link

(Being explicit about which files to include in the compilation is the right thing, for what my review of this change is worth.)

@benjie
Copy link
Member Author

benjie commented May 23, 2017

Sorry, I've no theory on this (and the window for it having failed is pretty wide, so I suspect a lot of dependencies have changed in this time). Good luck!

@benjie benjie removed the request for review from ferdinandsalis May 24, 2017 09:33
@benjie benjie merged commit 3e2b9d0 into master May 24, 2017
Belline pushed a commit to Belline/postgraphql that referenced this pull request Dec 18, 2017
* Fix FATAL ERROR: ... JavaScript heap out of memory

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

microsoft/TypeScript#14628

* Fix out of date commander API
@benjie benjie deleted the fix-ci branch June 22, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants