html-encode text passed to Ext.Msg #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
=======================================
Coverage 79.62% 79.62%
=======================================
Files 85 85
Lines 8847 8847
Branches 1893 1893
=======================================
Hits 7044 7044
Misses 1544 1544
Partials 259 259Continue to review full report at Codecov.
|
Member
|
@cbowman0 - could you please take a peek on this PR, please? Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ext.Msg.alertdoesn't automatically escape HTML special characters in the message, which can lead to display issues and could be a potential area for XSS.The new
htmlEncodefunction added errs on the side of caution by encoding all characters other than alphanumeric and space.