whisper.py and deepsource contradict eachother

[j340m3]

Hi,

i wanted to implement median as additional aggregation method. For state values which are usually represented as integers, there is no way to get a meaningful representative value. When I use average, the Integer will become a float which doesn't make sense anymore.

So i started working on #345 because it is relatively straightforward. When I made the pull request, deepsource had some issues with the code, so for the last 2 hours, I'm playing whack-a-mole against deepsource.

When i tried to resolve PTC-W0062, the assignment of deepsource was to join the two with statements into one. But in the code in whisper.py, I'm advised to keep it in multiple lines:

  # Python 2.7 will allow the following commented line
  # with open(path_from, 'rb') as fh_from, open(path_to, 'rb+') as fh_to:
  # But with Python 2.6 we need to use this (I prefer not to introduce
  # contextlib.nested just for this):

I'm a bit confused how I can help improve this project. Is the deepsource run only a suggestion? If so, how can I tell if the code satisfies your coding standards?

Please help me out here, I'am willing to invest my time and knowledge to implement this feature

[deniszh]

Hi @j340m3

Sorry for that! Deepsource is indeed only a suggestion, you can mostly ignore it.

[j340m3]

Since you plan on deprecating older Python versions, could I go on and follow deepsources advises, so that the code base will be lifted to modern standards? Or what are your plans in this regard?