Skip to content

SDLSorter fixes #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

SDLSorter fixes #329

merged 1 commit into from
Jun 27, 2023

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Jun 26, 2023

  • Throw exceptions properly
  • Sort by the specified string comparison properly

@Shane32 Shane32 self-assigned this Jun 26, 2023
@Shane32 Shane32 changed the base branch from master to v8 June 26, 2023 02:42
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v8@5be1a2d). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff          @@
##             v8     #329   +/-   ##
=====================================
  Coverage      ?   96.30%           
=====================================
  Files         ?       87           
  Lines         ?     4974           
  Branches      ?      494           
=====================================
  Hits          ?     4790           
  Misses        ?      184           
  Partials      ?        0           

@Shane32 Shane32 added this to the 8.4 milestone Jun 26, 2023
@Shane32 Shane32 merged commit e5bc3f9 into v8 Jun 27, 2023
@Shane32 Shane32 deleted the fix_sort branch June 27, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants