Skip to content

Add DefaultVisitorContext and NullVisitorContext #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Jul 18, 2023

  • Adds NullVisitorContext for use with synchronous visitors that do not hold context variables
  • Adds DefaultVisitorContext for use with asynchronous visitors that do not hold context variables

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v8@e5bc3f9). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff          @@
##             v8     #336   +/-   ##
=====================================
  Coverage      ?   96.29%           
=====================================
  Files         ?       89           
  Lines         ?     4970           
  Branches      ?      471           
=====================================
  Hits          ?     4786           
  Misses        ?      184           
  Partials      ?        0           

@Shane32 Shane32 added the enhancement New feature or request label Jul 18, 2023
@Shane32 Shane32 merged commit 98020b9 into v8 Jul 22, 2023
@Shane32 Shane32 deleted the add_default_contexts branch July 22, 2023 16:50
@Shane32 Shane32 linked an issue Oct 11, 2023 that may be closed by this pull request
/// Ideal for use in cases where the visitor runs synchronously, there is no context
/// variables, and cancellation is not required.
/// </summary>
public struct NullVisitorContext : IASTVisitorContext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readonly struct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested feature: default AST visitor context
3 participants