-
Notifications
You must be signed in to change notification settings - Fork 43
Add codecoverage, CodeQL analysis, dotnet-format #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It works! https://coveralls.io/builds/34609689 |
@joemcbride @Shane32 PR is finally ready for review. I added new actions in test job for calculating code coverage. Modified steps:
New steps:
Questions:
After we get everything in order here, I would like to add the same steps to other repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Do you think we should add "html" and "htmlsummary" outputs to the build artifacts for the test? See: https://github.com/Shane32/ExcelLinq/pull/3/files for necessary changes Sample output: download artifacts from here: I'm going to do this for my private repos instead of paying for coveralls pro. |
I was expecting this question. I also use ReportGenerator on my projects at work. We use TeamCity and there it is possible to display artifacts on a separate project tab, just point to some 'root' file to render (index.html). It's convenient, you don't need to download anything and the report is always in front of your eyes. The report really helps to understand what the code is not covered by the tests. In the case of GitHub Action, I'm not sure that someone will download this report as artifact. At least I won't, it's not convenient for me and I'm just lazy. For me it is much more convenient to configure systems such as coveralls or codecov to do all the work of displaying and maintaining coverage statistics. Of course, the question is how convenient these systems are and their cost. I have no experience with them.
What gives pro compared to what is given for free? As a conclusion. I was going to read general information about different code coverage web systems to compare them and evaluate their pros and cons. |
Coveralls free isn’t free for private repos. If you’ve got a better solution for private repos, I’m all ears. |
I don't khow, my primary goal are public repos like GraphQL.NET, Parser. etc. |
# Conflicts: # .github/workflows/publish-release.yml
# Conflicts: # README.md # src/GraphQLParser.ApiTests/ApiApprovalTests.cs # src/GraphQLParser/LexerContext.cs
No description provided.