Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Resolve can return value or raise, or use tuples #112

Merged
merged 1 commit into from
Dec 21, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/graphql/execution/resolvable.ex
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ end
defmodule GraphQL.Execution.ResolveWrapper do
def wrap(fun) do
try do
{:ok, fun.()}
case fun.() do
{:ok, result} -> {:ok, result}
{:error, message} -> {:error, message}
result -> {:ok, result}
end
rescue
e in RuntimeError -> {:error, e.message}
_ in FunctionClauseError -> {:error, "Could not find a resolve function for this query."}
Expand Down
31 changes: 31 additions & 0 deletions test/graphql/execution/executor_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,37 @@ defmodule GraphQL.Execution.Executor.ExecutorTest do
assert_data(result, %{b: "B"})
end

test "resolvers can return value or raise error, or :ok/:error tuples" do
schema = Schema.new(%{
query: %ObjectType{
name: "Q",
fields: %{
a: %{
type: %String{},
resolve: fn(_) -> "A" end
},
b: %{
type: %String{},
resolve: fn(_) -> {:ok, "B"} end
},
c: %{
type: %String{},
resolve: fn(_) -> raise "C" end
},
d: %{
type: %String{},
resolve: fn(_) -> {:error, "D"} end
}
}
}
})

{:ok, result} = execute(schema,~S[query Q { a b c d }])
assert_data(result, %{a: "A", b: "B", c: nil, d: nil})
assert_has_error(result, %{message: "C"})
assert_has_error(result, %{message: "D"})
end

test "lists of things" do
book = %ObjectType{
name: "Book",
Expand Down