This repository was archived by the owner on Jul 25, 2024. It is now read-only.
Executor refactoring #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshtonic
force-pushed
the
refactor/executor-return-values
branch
from
213294f to
fb7cae3
Compare
|
The |
This will allow us to report errors from anywhere in the flow and accumulate them in the ExecutionContext.
freshtonic
force-pushed
the
refactor/executor-return-values
branch
from
cc3f714 to
f6027f9
Compare
|
Great work! Since we're changing the primary interface for the lib, we should maintain compatibility functions and deprecate them for the next version. This will also need the corresponding changes in plug. This should also resolve #56 and #64 but needs testing. #65 should also pass now so lets pull that into this PR. |
This was referenced Apr 30, 2016
After new version of plug is released that uses the new execute function, the old execute function will be deleted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for review and merge. Once this is done, I'll rebase the mutations code on top.