Skip to content

Fix isNullish to properly handle typed nil #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Fix isNullish to properly handle typed nil #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1d09470
Fix isNullish to properly handle nil behind the interface.
samuel Jan 22, 2016
c6147fb
rewrite imports
samuel Feb 9, 2016
886e9fd
Handle panics and error types.
samuel Feb 9, 2016
54108d7
Cherry pick https://github.com/graphql-go/graphql/pull/108
samuel Feb 10, 2016
0e0b957
Support omitempty tag option
samuel Feb 10, 2016
eb470b9
Increase stack trace from 1k to 4k
samuel Feb 12, 2016
8af96fb
Small optimization to lexer
samuel Apr 29, 2016
3b07371
Use an immutable lexer source for more efficient rune lookups.
samuel Apr 29, 2016
25605ba
Minor cleanup and optimizations
samuel Apr 29, 2016
e9c0f2d
Cleanup ast pkg
samuel Apr 29, 2016
637b7ba
Simplifty and optimize AST printer
samuel Apr 30, 2016
7c83c39
Slight cleanup to validator and add benchmark
samuel May 1, 2016
4aab0d7
Rewrite visitor to avoid reflection and allocations.
samuel May 23, 2016
989ea12
Small validator cleanup and optimization
samuel May 23, 2016
ca81145
Remove invariant to avoid formatting strings until necessary.
samuel May 25, 2016
df2dad3
Fix concurrency issues and cache schema defs.
samuel May 25, 2016
ded2783
Reduce allocations in visitor
samuel May 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions abstract_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import (
"reflect"
"testing"

"github.com/graphql-go/graphql"
"github.com/graphql-go/graphql/gqlerrors"
"github.com/graphql-go/graphql/language/location"
"github.com/graphql-go/graphql/testutil"
"github.com/sprucehealth/graphql"
"github.com/sprucehealth/graphql/gqlerrors"
"github.com/sprucehealth/graphql/language/location"
"github.com/sprucehealth/graphql/testutil"
)

type testDog struct {
Expand Down Expand Up @@ -405,7 +405,7 @@ func TestResolveTypeOnInterfaceYieldsUsefulError(t *testing.T) {
},
},
Errors: []gqlerrors.FormattedError{
gqlerrors.FormattedError{
{
Message: `Runtime Object type "Human" is not a possible type for "Pet".`,
Locations: []location.SourceLocation{},
},
Expand Down Expand Up @@ -523,7 +523,7 @@ func TestResolveTypeOnUnionYieldsUsefulError(t *testing.T) {
},
},
Errors: []gqlerrors.FormattedError{
gqlerrors.FormattedError{
{
Message: `Runtime Object type "Human" is not a possible type for "Pet".`,
Locations: []location.SourceLocation{},
},
Expand Down
Loading