Skip to content

Update README.md - Fix #175 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Update README.md - Fix #175 #198

merged 2 commits into from
Apr 21, 2017

Conversation

christianpv
Copy link
Contributor

I updated the documentation regarding current spec implementation.

I updated the documentation regarding current spec implementation.
@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 82.605% when pulling fd19735 on christianpv:patch-1 into 170c5b5 on graphql-go:master.

@bbuck
Copy link
Collaborator

bbuck commented Apr 14, 2017

I see you added details about where graphql-js is in relation to the spec and where the spec is but did you update where this project is currently at?

@christianpv
Copy link
Contributor Author

I believe I did. This is a part of the update to README.md: graphql is currently on v0.6.0 of graphql-js.
If this is not what you mean, could you elaborate? Thanks!

@bbuck
Copy link
Collaborator

bbuck commented Apr 17, 2017

Ahh, if hmm. That was the confusion you said "graphql is currently ..." I think we should probably use some other language, like "this project" or "Go implementation" or just "graphql-go" (just to set it a part from every other usage of graphql in that paragraph. Already seeing a few users hopping over to the clearly labeled graphql-go gitter channel and asking for help with graphql-js so I know this can confuse others.

addressing feedback
@coveralls
Copy link

coveralls commented Apr 21, 2017

Coverage Status

Coverage decreased (-0.02%) to 82.585% when pulling a915771 on christianpv:patch-1 into 170c5b5 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 - thanks a lot @christianpv

@chris-ramon chris-ramon merged commit 44a52a8 into graphql-go:master Apr 21, 2017
@christianpv christianpv deleted the patch-1 branch April 22, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants