fixed issue with pointer to scalar values - #199
Merged
Merged
Conversation
…oded (if the value is nil) correctly
jhaynie
changed the title
Member
|
LGTM 👍 — thanks a lot @jhaynie |
deoxxa
pushed a commit
to deoxxa/graphql-go
that referenced
this pull request
Dec 11, 2017
This is a rebased and updated version of @tgriesser's graphql-go#199. I further extended it to completely remove the side-effectful mutation of Interface types rather than just deferring that mutation to schema creation time. This introduces a *breaking* change to the Type System API. Now, any individual Interface type does not have the required information to answer `getPossibleTypes` or `isPossibleType` without knowing the other types in the Schema. These methods were moved to the Schema API, accepting the abstract type as the first parameter. This also introduces a *breaking* change to the type comparator functions: `isTypeSubTypeOf` and `doTypesOverlap` which now require a Schema as a first argument. Commit: 6a1f23e1f9c1e6bf4cea837bc9bb6eae0fb5c382 [6a1f23e] Parents: a781b556ee Author: Lee Byron <lee@leebyron.com> Date: 23 March 2016 at 1:17:43 PM SGT Commit Date: 25 March 2016 at 6:35:39 AM SGT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a response struct like the following:
And
Barisnil. The result will be incorrectly encoded on returning. The result will be\u003cnil\u003einstead ofnull(when serialized to JSON).This fix will fix
isNullishto check for*stringtype and other primitive types.