[sentry plugin] Adds an error before using the rootSpan if it's not been set up #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orta is attempting to deploy a commit to the The Guild Team on Vercel. A member of the Team first needs to authorize it. |
n1ru4l
reviewed
Jun 27, 2022
| if (!rootSpan) { | ||
| const error = [ | ||
| `Could not create the root Sentry transaction for the GraphQL operation "${transactionName}".`, | ||
| `It's very likely that this is because you have not included the Sentry tracing SDK in your app's runtime before handling the request.`, |
There was a problem hiding this comment.
@orta Do you think it would be nice to also include a link here that points to the corresponding sentry documentation?
There was a problem hiding this comment.
We can do this in a follow-up PR.
n1ru4l
approved these changes
Jun 27, 2022
🦋 Changeset detectedLatest commit: 8bf11fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
👋 It is possible to set up Sentry so that
rootSpan = Sentry.startTransactionreturns null. This is always a user-side sentry setup issue, but because it will crash the plugin I wasn't seeing any logs about what was going on. getsentry/sentry-javascript#4731Fixes (no issue, didn't seem worth it for a more explicit log)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: