Skip to content

FallbackSubscriptionProtocolHandler should preserver the session #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guitcastro opened this issue Dec 4, 2018 · 0 comments
Closed

FallbackSubscriptionProtocolHandler should preserver the session #137

guitcastro opened this issue Dec 4, 2018 · 0 comments
Labels
enhancement
Milestone
8.0.0

Comments

@guitcastro
Copy link

I am trying to use websocket for both subscriptions and query, using the DataFetchingEnvironment to get my user Principal by doing env.context.session.userPrincipal.

The ApolloSubscriptionProtocolHandler handle this in the createInvocationInput method, we should to this as well in the FallbackSubscriptionProtocolHandler so even if is not a subscription query the websocket session is available for authentication or any other use case related to the have the WSSession in the env.context
@oliemansm oliemansm added this to the 7.5.1 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@guitcastro @oliemansm