Relaxed Jakarta Servlet API version to 5.x in GraphQL Java Servlet #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relaxed Jakarta Servlet API version to 5.x for 'api' dependencies - Kept Jakarta Servlet API version at 6.x for 'testImplementation' dependencies - since Jakarta Servlet API 6.x is required only for tests
|
Possibly a separate branch, |
|
Is there any interesst in merging this, as we would highly appreciate this change as well. |
|
@ideas-into-software We created the @oliemansm you can close this PR |
|
Closing this as @federicorispo added this to https://github.com/graphql-java-kickstart/graphql-java-servlet/tree/jakarta5 branch via 72fba8b commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Federico Rispo's comment Federico Rispo's comment (#508 (comment)),
GraphQL Java Servletis dependent onJakarta Servlet 6.xonly because ofSpringdependencies, which are only used for testing. Therefore, it was possible to relaxJakarta Servlet APIversion to5.x, while keepingJakarta Servlet APIversion at6.xfor 'testImplementation' dependencies.Most of our projects use
Apache Felix Jettyand requiringJakarta Servlet 6.xmade it impossible to use that container.Thanks to this small change,
GraphQL Java Servletis now compatible with latest version ofApache Felix Jetty, as well as many other servlet containers which do not yet supportJakarta Servlet 6.x.