294 handle optional parameters #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he parameter is absent.
vojtapol
changed the title
|
Someone accept this person's PR. It's super valuable. |
|
@oliemansm Is there anything blocking this PR? I can update it with any requested changes if necessary. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #294
The issue describes the problem. This simple fix would make the library more consistent with graphql-java. It would also allow for easy differentiation between absent and
nullarguments.null-> argument was omitted from the queryOptional.empty()-> argument was not omitted and it was set to GraphQLnullIt makes it possible to use GraphQL
nullin mutations for clearing values without using theenvironment.containsArgumentworkaround.