Skip to content

Adding Java Scalars #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2020
Merged

Adding Java Scalars #20

merged 4 commits into from
Feb 5, 2020

Conversation

simeonleatherland
Copy link

  • Moving Java Scalar types from graphql-java

@simeonleatherland
Copy link
Author

Note for @andimarek - I was unsure if this was the right place to put them so let me know if you think they should be in a more appropriate place :D

@simeonleatherland simeonleatherland mentioned this pull request Jan 30, 2020
Closed
bbakerman
bbakerman requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the code organisation challenges

bbakerman
bbakerman requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the tests to use ExtendedScalars. GraphQLxxx from the top so we KNOW we have coverage from where we expected people to consume them

@bbakerman bbakerman merged commit 6f82be9 into graphql-java:master Feb 5, 2020
@simeonleatherland simeonleatherland deleted the AddingJavaScalars branch February 5, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

@andimarek andimarek Awaiting requested review from andimarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simeonleatherland @bbakerman