Allow bumped version of aniso8601 #1042
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 6 aniso8601 some rounding bugs were introduced. See the issue reported here: https://bitbucket.org/nielsenb/aniso8601/issues/24/float-induced-rounding-errors-when-parsing See the commit that fixed it here: https://bitbucket.org/nielsenb/aniso8601/commits/b4aca8ffc25588128d1c463ca735c8d6f180f55a Allow for a higher version to allow graphene users to avoid these issues.
jasonrfarkas
requested review from
dan98765,
ekampf,
jkimbo and
ProjectCheshire
as code owners
|
There is #1009 already opened for it 👍 |
|
Ah great! - this one doesn't have the merge conflict though :) |
|
Thanks for the PR @jasonrfarkas but I just merged #1009 so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 6 aniso8601 some rounding bugs were introduced.
See the issue reported here: https://bitbucket.org/nielsenb/aniso8601/issues/24/float-induced-rounding-errors-when-parsing
See the commit that fixed it here: https://bitbucket.org/nielsenb/aniso8601/commits/b4aca8ffc25588128d1c463ca735c8d6f180f55a
Allow for a higher version to allow graphene users to avoid these issues.