Add support for graphql-core 3.2.0 #1415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From graphql-core 3.2 ref graphql-python/graphql-core@09ff14f
From our CI:
tests/test_app/test_service/conftest.py:9: in <module> from graphene.test import Client as GraphqlClient /opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/graphene/test/__init__.py:2: in <module> from graphql.error import format_error as format_graphql_error E ImportError: cannot import name 'format_error' from 'graphql.error' (/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/graphql/error/__init__.py)Currently running
graphene==3.0b7in CI which allowsgraphql-core==3.2.0:If I try pinning
graphene==3.0b8orgraphene==3.0.0(and thereby disallowgraphql-core==3.2.0), our installation breaks as all stable versions ofgql(except 0.1.0) requiregraphql-core>=3.2.0:version tree
Workaround for now: fall back to
graphene==3.0andgql==3.0.0rc0version tree
Is there anything else needed here for 3.2 support? ref b6c8931