Skip to content

Update middleware.rst #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dani0805
Copy link

I think a description of where the Middleware needs to go to be executed every time would be useful. It would have saved me some time.

I think a description of where the Middleware needs to go to be executed every time would be useful. It would have saved me some time.
@syrusakbary
Copy link
Member

syrusakbary commented Aug 29, 2018

Hi @dani0805, this PR belongs to the Graphene-Django docs, not to the base Graphene Docs.
Please reopen there the PR for re-review :)

@dani0805 dani0805 deleted the patch-1 branch August 31, 2018 10:56
@dani0805
Copy link
Author

In graphene-django this part of the documentation is completely missing. Someone could extrapolate by looking how the debug middleware is deployed and then see the base documentation for general guide about how to develop a new middleware.

But if you are not the one that installed graphene-django and you never saw it in settings, you might be trying to use the direct call example that is in the base documentation.

Would it make sense to:

  1. repeat the explanation in graphene-django including deployment or,
  2. reference the debug middleware django (and possibly flask if it even makes sense ) in the base documentation so that people using Django can find it easily

Let me know what you think and I can adapt it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants