Closed
Conversation
ryanwang520
force-pushed
the
coerce_str
branch
from
586e2f4 to
8c784d4
Compare
ryanwang520
force-pushed
the
coerce_str
branch
from
8c784d4 to
bbfb738
Compare
Member
|
Thanks for contributing. I looked into this and found that the addressed behavior and tests in GraphQL-core are the same as in GraphQL.js. Since the goal of GraphQL-core is to be a faithful replication of GraphQL.js which is considered the "reference implementation", I really do not want to introduce incompatible changes in GraphQL-core. If you think this really needs to be changed, you have two options: 1. Create an issue in the GraphQL.js project. and convince them to implement the change there - don't worry, they are open for such suggestions and discussions. If it is accepted, it will then be ported to GraphQL-core as well. 2. Try to change it at a higher level, e.g. in Graphene. |
Author
|
Ok, I would just try some other workaround. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's convenient for frontend to pass
stras some value ofInttype, maybe it's too strict to reject valid int str .By the way, I tried to upgrade a project from
graphene 2tographene 3and found that ingraphene 2str would coerce to int correctly whilegraphene 3just throws the errorInt cannot represent non-integer value:, which I think is caused by thecoerce_intfunction here.