Create async loop outside of benchmark #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised that the async benchmark in #141 wasn't a fair comparison to the sync one because it was also including the async loop setup. This PR creates the async loop outside of the benchmark code to more accurately benchmark the actual query execution.
There is still some overhead with the async execution but it's no longer as bad as the first benchmark (more like ~20% slower rather than ~70%)
