chore: use pre-commit and ruff #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiendang
force-pushed
the
ruff-pre-commit
branch
4 times, most recently
from
4905b2a to
8c20a38
Compare
|
Also added C4 flake8-comprehensions. See graphql-python/graphene-django#1441 (comment). |
kiendang
force-pushed
the
ruff-pre-commit
branch
from
f22bd66 to
9d94a01
Compare
kiendang
force-pushed
the
ruff-pre-commit
branch
from
9d94a01 to
259dd75
Compare
erikwrede
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the formatters and linters into pre-commit with ruff. The benefits are:
black,isort,flake8, ... in a separate tox env.black,isort,flake8, ... can be removed from dependencies. Earlier there were problems with updating their versions since they caused dependency conflicts with the framework packages.