-
Notifications
You must be signed in to change notification settings - Fork 70
Update dependencies #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erikwrede
merged 15 commits into
graphql-python:master
from
kiendang:update-dependencies
Dec 25, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
72a9eea
Update dependencies
kiendang 7b45e70
Relax flask dependency to allow flask 2
gcampax d184cdc
Fixes for quart >=0.15
Choongkyu 8bacf9a
Lint
kiendang ee5b077
Fix aiohttp tests
kiendang 80d3f7c
Update sanic to v22.6
kiendang 271b447
Make sanic v22.9 work
kiendang aac23bc
Fix deprecation warnings
kiendang 6623379
Update graphiql to 1.4.7 for security reason
kiendang 68ff98d
Fix webob graphiql check
kiendang d1d8835
Fix quart PytestCollectionWarning
kiendang 2b58b9a
Make Jinja2 optional
kiendang fa48065
Add python 3.11 and remove 3.6
kiendang 3673f76
Tweak quart for python 3.7 to 3.11
kiendang ff2d087
Fix test for python 3.11
kiendang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
"""Based on (express-graphql)[https://github.com/graphql/express-graphql/blob/master/src/renderGraphiQL.js] and | ||
"""Based on (express-graphql)[https://github.com/graphql/express-graphql/blob/main/src/renderGraphiQL.ts] and | ||
(subscriptions-transport-ws)[https://github.com/apollographql/subscriptions-transport-ws]""" | ||
import json | ||
import re | ||
|
@@ -7,7 +7,7 @@ | |
from jinja2 import Environment | ||
from typing_extensions import TypedDict | ||
|
||
GRAPHIQL_VERSION = "1.0.3" | ||
GRAPHIQL_VERSION = "1.4.7" | ||
|
||
GRAPHIQL_TEMPLATE = """<!-- | ||
The request to this GraphQL server provided the header "Accept: text/html" | ||
|
@@ -34,12 +34,12 @@ | |
} | ||
</style> | ||
<link href="//cdn.jsdelivr.net/npm/graphiql@{{graphiql_version}}/graphiql.css" rel="stylesheet" /> | ||
<script src="//cdn.jsdelivr.net/npm/promise-polyfill@8.1.3/dist/polyfill.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/unfetch@4.1.0/dist/unfetch.umd.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/react@16.13.1/umd/react.production.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/react-dom@16.13.1/umd/react-dom.production.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/promise-polyfill@8.2.0/dist/polyfill.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/unfetch@4.2.0/dist/unfetch.umd.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/react@16.14.0/umd/react.production.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/react-dom@16.14.0/umd/react-dom.production.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/graphiql@{{graphiql_version}}/graphiql.min.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/[email protected].16/browser/client.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/[email protected].18/browser/client.js"></script> | ||
<script src="//cdn.jsdelivr.net/npm/[email protected]/browser/client.js"></script> | ||
</head> | ||
<body> | ||
|
@@ -308,9 +308,8 @@ async def render_graphiql_async( | |
jinja_env: Optional[Environment] = config.get("jinja_env") | ||
|
||
if jinja_env: | ||
# This method returns a Template. See https://jinja.palletsprojects.com/en/2.11.x/api/#jinja2.Template | ||
template = jinja_env.from_string(graphiql_template) | ||
if jinja_env.is_async: # type: ignore | ||
if jinja_env.is_async: | ||
source = await template.render_async(**template_vars) | ||
else: | ||
source = template.render(**template_vars) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
from quart.typing import TestClientProtocol | ||
|
||
TestClientProtocol.__test__ = False # type: ignore |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not update to
2.2.0
straight away?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should upgrade to 2.2.0. I was basing this on https://github.com/graphql/express-graphql/blob/main/src/renderGraphiQL.ts plus the graphiql readme recommending upgrading to 1.4.7 so I was under the impression that 1.4.7 is the latest version. Will try upgrading to 2.2.0 and verifying that everything's working, but maybe we should merge this first and I'll submit a subsequent PR for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!