-
Notifications
You must be signed in to change notification settings - Fork 432
Preserve the order of requested fields #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the spec recommends it, I'm definitely in favor. Thanks for the PR, @LegNeato! There are two open questions for me:
Is there maybe another order preserving hashmap crate around which is better maintained? |
Re: perf, I couldn't get Re: |
Can't we switch to OrderMap and use remote derive for now? |
I just tried and it doesn't look like you can use remote derive for this, as just using #[derive(Serialize, Deserialize)]
#[serde(remote = "OrderMap")] Fails as the default derive isn't sufficent and #[serde(remote = "OrderMap")] fails without I'm a Rust n00b, so if there is a way to do this that I am missing please let me know! |
457588e
to
7c9abe1
Compare
7c9abe1
to
ab19288
Compare
I got them to do a release, so latest changes use |
Nice to see that you get some utility out of ordermap. As a point of order, you'll should probably add Ordermap's 1.0-ing on your own 1.0 road map, since it's a “public dependency” when used like this. OrderMap itself doesn't have an 1.0 road map, for the record, but the future is open ended. |
Thanks for this PR! Bringing us closer to spec compliance :) |
Fixes #82
Note: I am new to Rust, please let me know if there is anything I can do better.