-
Notifications
You must be signed in to change notification settings - Fork 2k
Circular import breaks building with Google Closure Compiler #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The simplest solution would be to just merge @Jannis Do you want to work on this PR? |
@IvanGoncharov Sure, I can cook something up. |
Jannis
pushed a commit
to Jannis/graphql-js
that referenced
this issue
Mar 6, 2018
This fixes graphql#1275 by avoiding circular imports between the two modules.
Jannis
pushed a commit
to Jannis/graphql-js
that referenced
this issue
Mar 6, 2018
Jannis
pushed a commit
to Jannis/graphql-js
that referenced
this issue
Mar 6, 2018
Jannis
pushed a commit
to Jannis/graphql-js
that referenced
this issue
Mar 6, 2018
Jannis
pushed a commit
to Jannis/graphql-js
that referenced
this issue
Mar 6, 2018
leebyron
pushed a commit
that referenced
this issue
Mar 7, 2018
This was referenced Mar 19, 2018
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a circular dependency between
type/definition.js
andtype/wrappers.js
, which breaks building graphql-js with the Google Closure Compiler (which has no solution to breaking circular imports yet, see this issue).The affected code is located here:
https://github.com/graphql/graphql-js/blob/master/src/type/definition.js#L35
and
https://github.com/graphql/graphql-js/blob/master/src/type/wrappers.js#L10-L11
Any chance we could break this cycle? Among other things, it would allow to include graphql-js seamlessly in ClojureScript via its new
:npm-deps
feature.The text was updated successfully, but these errors were encountered: