-
Notifications
You must be signed in to change notification settings - Fork 2k
suggestions #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestions #4219
Conversation
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
I'm not totally sure about the argument ordering, I'm not happy to separate variableValues and fragmentVariableValues, and I'm not happy to put maskSuggestions earlier, because that would be a breaking change, so I settled on putting maskSuggestions later, which is fine, except that if we ever revert the fragment arguments experiments, that would end up being a breaking change... Now, I don't ==think== we are going to revert it.... thoughts on that minor issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but in general this feels very nitpicky about argument ordering 😅 all for avoiding a breaking change and maybe it's better to even use options consistently in collectFields as well but all the other changes are styllistic
44b356c
to
ff2087d
Compare
4a1ef07
to
268f8fc
Compare
d6af6ea
to
10475bb
Compare
includes: