Make the default resolver use args and context #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the default resolver is really handy in some cases. If you have a field that uses args and/or context, though, you can't use a default resolver because the default resolver just throws them away, even if there's a function hanging off the source object. There's no real benefit to that behavior, so this PR passes args and context along to the function hanging off the source object if there is one. This makes it easier to use es6 classes in conjunction with graphql.js.
This is backward compatible unless you happened to use a default resolver method which relied on not receiving any arguments despite the schema allowing arguments, which seems perverse enough that we can ignore that case.