Skip to content

Do not warn about legacy __configs__ name #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not warn about legacy __configs__ name #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/utilities/assertValidName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ export function assertValidName(
`Must be named. Unexpected name: ${name}.`
);
}
if (!isIntrospection && name.slice(0, 2) === '__' && !hasWarnedAboutDunder) {
// For legacy reasons, __type__ and __configs__ should not generate a warning
// until the usage of these fields is cleaned up from the Facebook internal
// schemas.
if (
!isIntrospection &&
name.slice(0, 2) === '__' &&
name !== '__configs__' &&
name !== '__type__' &&
!hasWarnedAboutDunder
) {
hasWarnedAboutDunder = true;
/* eslint-disable no-console */
if (console && console.warn) {
Expand Down