This repository was archived by the owner on Sep 2, 2020. It is now read-only.
Fixes #221 and #222 - fixes GraphQLCache file globbing #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostplan
reviewed
Apr 11, 2018
packages/server/src/GraphQLCache.js
Outdated
| @@ -246,9 +242,15 @@ export class GraphQLCache implements GraphQLCacheInterface { | |||
| rootDir: string, | |||
| includes: string[], | |||
| ): Promise<Array<GraphQLFileMetadata>> => { | |||
| let pattern: string; | |||
| if (includes.length === 1) { | |||
There was a problem hiding this comment.
I don't think it's a bug. It sort of depends on which implementation of globs you look at. Some of them (fish shell) expanded a{p}e into ape and others (bash, sh, minimatch) leave a{p}e as is. My guess is that minimatch is modeled after bash and filing a ticket will be fruitless.
There was a problem hiding this comment.
I just mean we should add a note-to-self about why length === 1 is special cased (i.e. a link to #221). To prevent future engineers from cleaning up this code.
There was a problem hiding this comment.
Ah, no problem. I'll update the PR with a comment.
lostplan
approved these changes
Apr 11, 2018
|
I've added tests.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detailed descriptions of issues in #221 and #222.