Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

Fixes #223 - handle case when .graphqlconfig defines projects #225

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

mgadda
Copy link
Collaborator

@mgadda mgadda commented Apr 11, 2018

In addition to fix the issue details in #223, this patch also addresses the errors we were seeing in the console this morning:

(node:4595) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot convert undefined or null to object
(node:4595) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The above unhandled error was raised by invoking Object.values(undefined) in MessageProcessor.js in the case where a .graphqlconfig file defined project-level settings.

@mgadda mgadda requested review from lostplan and asiandrummer April 11, 2018 03:26
@lostplan lostplan merged commit a937700 into graphql:master Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants