Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

Feature go to definition SDL - input, enum, type #237

Merged
merged 8 commits into from
Jun 3, 2018
Merged

Feature go to definition SDL - input, enum, type #237

merged 8 commits into from
Jun 3, 2018

Conversation

divyenduz
Copy link
Contributor

  1. Implement go to definition for input, enum, type in SDL with some test cases

  2. Support live file reload

  3. Fixes a related test case in getDefinition that was found while implementing this part of code i.e. I think it belongs here

Thanks! :)

Copy link
Contributor

@asiandrummer asiandrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock. I haven't gone through the entire PR yet, so I might be coming back later and making some comments.

README.md Outdated
@@ -14,6 +14,7 @@ Currently supported features include:
- Diagnostics (GraphQL syntax linting/validations) (**spec-compliant**)
- Autocomplete suggestions (**spec-compliant**)
- Hyperlink to fragment definitions (**spec-compliant**)
- Hyperlink to named types (type, input, enum) definitions (**spec-compliant**)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just merge it above:

Hyperlink to fragment and named types (type, input, enum) definitions 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@asiandrummer asiandrummer merged commit cc6b063 into graphql:master Jun 3, 2018
@schickling schickling mentioned this pull request Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants