Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

WIP: Allow passing ParseOptions to parse() with GraphQL Language Server #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamjernst
Copy link

I want to pass some ParseOptions. The obvious way to do this is to specify it in .graphqlconfig and make graphql-language-service pick this up and respect it.

This is only a start. I haven't figured out the cleanest way to pass this to GraphQLCache. That will come next.

I want to pass some ParseOptions. The obvious way to do this is to specify it in `.graphqlconfig` and make graphql-language-service pick this up and respect it.

This is only a start. I haven't figured out the cleanest way to pass this to `GraphQLCache`. That will come next.
Copy link
Contributor

@asiandrummer asiandrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - looking forward to the next iteration!

@acao
Copy link
Member

acao commented Dec 13, 2019

almost two years later, still more than welcome @adamjernst , otherwise i can take this and run with it with attribution of course! we've migrated this repo since. sorry things got stagnant for a bit. if i dont hear back in a week, I will go ahead and migrate this, as we're trying to migrate out the last from the old repos

@adamjernst
Copy link
Author

Sorry @acao, I forgot about this! Please do run with it!

@acao
Copy link
Member

acao commented Dec 13, 2019

@adamjernst great thanks will do, this is a solid and important addition to the graphql-config support matrix we have so far.

was just summarizing it in an issue i'm about to open in discussion on what we can do with graphql-config next, and what interface -> config service -> extension layers we can design moving forward. this will come in handy for the browser side even soon, youll see ❗️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants