Skip to content

Improve clarity of built-in directives #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 26, 2021
Merged

Improve clarity of built-in directives #633

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
27e7720
Improve clarity of standard directives
sungam3r Oct 26, 2019
cecf7fd
can be -> should be
sungam3r Oct 26, 2019
37df075
should -> can
sungam3r Oct 26, 2019
14a8c0f
formatting
sungam3r Oct 26, 2019
cfe4e35
merge notes about standard directives to **built-in directives**
sungam3r Oct 27, 2019
f5cd6ba
typo
sungam3r Oct 27, 2019
f0c1fb7
review
sungam3r Oct 27, 2019
b9b2b75
Merge branch 'main' into directives
leebyron Apr 22, 2021
f485d89
Move built-in section above custom section
leebyron Apr 22, 2021
4e28da2
Generalize message and repeat in introspection section
leebyron Apr 22, 2021
ca86b8b
Use term definitions
leebyron Apr 22, 2021
706332e
Apply suggestions from code review
leebyron Apr 22, 2021
8534913
may omit built-ins for brevity
leebyron Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions spec/Section 3 -- Type System.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1692,6 +1692,13 @@ While defining a directive, it must not reference itself directly or indirectly:
directive @invalidExample(arg: String @invalidExample) on ARGUMENT_DEFINITION
```

When returning the set of directives from the `__Schema` introspection type, both
@skip and @include directives must be included. @deprecated directive may be included
if GraphQL implementation supports the type system definition language.

When representing a GraphQL schema using the type system definition language, both @skip,
@include and @deprecated directives should be omitted for brevity.

**Validation**

1. A directive definition must not contain the use of a directive which
Expand Down