-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[RFC] Default value coercion rules #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjie
wants to merge
15
commits into
graphql:main
Choose a base branch
from
benjie:input-object-default-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8939e20
Default value coercion rules
benjie 25da056
Fix 'must not cause an infinite loop' wording.
benjie f73af73
Reorder assertions to prevent infinite loop during coercion
benjie 5e793fb
Reduce diff
benjie 084b2d5
Clarify the default value cycle detection logic
benjie 475d697
Rewrite default value cycle algorithm in the style of DetectFragmentC…
benjie dde1f7b
Rewrite input object cycle algorithm to match GraphQL.js implementation
benjie 12e26d8
Asterisks
benjie 2838c4f
Remove unnecessary step
benjie 9b7bfd5
Add non-normative note about memoizing default value coercion
benjie bb6ab78
Merge branch 'main' into input-object-default-value
benjie 9a64519
Merge branch 'main' into input-object-default-value
benjie 8beb848
Rather than assertions, use return values.
benjie 4f76d6f
Fix accidental mutation
benjie 4bac8df
Merge branch 'main' into input-object-default-value
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in GraphQL.js via
createInputObjectDefaultValueCircularRefsValidator
factory'sdetectValueDefaultValueCycle
method.visitedFields
is implemented via a mutable object for memory efficiency, but each time a walk completes the changes are rolled back so it's functionally equivalent.