Skip to content

Add tags to blog posts & create tag pages #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

mikeesto
Copy link
Contributor

Closes #1033

Description

This PR adds tags to each blog post. When a tag is clicked on, it navigates to a new /tags route that shows all posts with the same tag.

Screen Shot 2021-04-13 at 3 50 07 pm

Apologies for the noise in the diffs. It appears prettier hadn't been run in a while on these files.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brianwarner
Copy link
Contributor

@mikeesto this is great! Thanks for doing this.

Do you know if it's possible to add the tags to the sidebar?

@mikeesto
Copy link
Contributor Author

mikeesto commented Apr 14, 2021

@brianwarner No worries!

Sure can. Did you have something/a design in mind? This is what I've got running locally:

Screen Shot 2021-04-14 at 6 00 44 pm

@brianwarner
Copy link
Contributor

That's great! Can we maybe call it "Categories"?

I really appreciate you doing this. I also see I didn't use consistent tags when I updated all the posts ("Announcement" vs. "Announcements") :-) I have a few things to push anyhow, I'll fix that when I do.

Thanks again!

@mikeesto
Copy link
Contributor Author

I've changed the section title to 'Categories' and looks good now with the fixed tags :)

@brianwarner
Copy link
Contributor

This is really great, @mikeesto. Thanks so much for doing this! One of the nicest parts is that we can now link directly to specific types of content (e.g., press releases, or technical content, or spec announcements, or whatever). LGTM.

@brianwarner
Copy link
Contributor

@mikeesto I think I fixed the deploy previews. I'm going to try closing and re-opening this PR to see if that triggers a preview build.

@brianwarner brianwarner reopened this Apr 15, 2021
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we should add linting to CI for prettier checks and add gatsby-plugin-typegen to generate TypeScript types from queries.

@brianwarner
Copy link
Contributor

This one has been open for a bit, so I'm going to go ahead and land it and we can iterate as needed. Thanks again, @mikeesto!

@brianwarner brianwarner merged commit 52cfab3 into graphql:source Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help wanted: add support for categories to the blog
4 participants