-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add tags to blog posts & create tag pages #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@mikeesto this is great! Thanks for doing this. Do you know if it's possible to add the tags to the sidebar? |
@brianwarner No worries! Sure can. Did you have something/a design in mind? This is what I've got running locally: |
That's great! Can we maybe call it "Categories"? I really appreciate you doing this. I also see I didn't use consistent tags when I updated all the posts ("Announcement" vs. "Announcements") :-) I have a few things to push anyhow, I'll fix that when I do. Thanks again! |
I've changed the section title to 'Categories' and looks good now with the fixed tags :) |
This is really great, @mikeesto. Thanks so much for doing this! One of the nicest parts is that we can now link directly to specific types of content (e.g., press releases, or technical content, or spec announcements, or whatever). LGTM. |
@mikeesto I think I fixed the deploy previews. I'm going to try closing and re-opening this PR to see if that triggers a preview build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should add linting to CI for prettier checks and add gatsby-plugin-typegen
to generate TypeScript types from queries.
This one has been open for a bit, so I'm going to go ahead and land it and we can iterate as needed. Thanks again, @mikeesto! |
Closes #1033
Description
This PR adds tags to each blog post. When a tag is clicked on, it navigates to a new
/tags
route that shows all posts with the same tag.Apologies for the noise in the diffs. It appears prettier hadn't been run in a while on these files.