RFC: Schema parser #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
force-pushed
the
schema-parser
branch
3 times, most recently
from
f8251ce to
429f22a
Compare
swolchok
force-pushed
the
schema-parser
branch
from
429f22a to
7591a42
Compare
Closed
|
Planning to hold off merging this until folks get a chance to return from the holidays. |
ttsugriy
reviewed
Dec 28, 2016
| yylex_destroy(scanner); | ||
| return result; | ||
| } | ||
|
|
||
| std::unique_ptr<ast::Node> parseFile(FILE *file, const char **error) { | ||
| std::unique_ptr<ast::Node> parseString(const char *text, const char **error) { | ||
| return parseStringImpl(text, error, false); |
There was a problem hiding this comment.
nit: it's hard to guess what is the meaning of the boolean without reading a type signature of parseStringImpl, so it's usually a good practice to leave a comment /* enableSchema */ right next to a parameter.
ttsugriy
reviewed
Dec 28, 2016
| @@ -1,6 +1,6 @@ | |||
| #line 1 "lexer.cpp" | |||
| #line 1 "/Users/swolchok/libgraphqlparser/lexer.cpp" | |||
There was a problem hiding this comment.
it's probably not something you'd like to leave :)
There was a problem hiding this comment.
Ugh, this keeps cropping up. cmake seems to run the tools by passing their absolute path. thanks.
swolchok
force-pushed
the
schema-parser
branch
from
7591a42 to
af91437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the RFC schema language additions in graphql/graphql-spec#90 .
Should fix #22 when complete.