Ensure clipboard data is shared in the format Windows expects #10284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyb89
approved these changes
Feb 10, 2022
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
dbbd0ee to
8ddcfd5
Compare
jimbishopp
reviewed
Feb 11, 2022
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
8ddcfd5 to
5d5aede
Compare
jimbishopp
reviewed
Feb 11, 2022
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
5d5aede to
0e1bb2c
Compare
jimbishopp
approved these changes
Feb 11, 2022
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
0e1bb2c to
d1e87ae
Compare
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
d1e87ae to
5383f7b
Compare
ibeckermayer
suggested changes
Feb 11, 2022
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
2 times, most recently
from
8aad396 to
6ac328c
Compare
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
6ac328c to
4e3e99e
Compare
ibeckermayer
approved these changes
Feb 11, 2022
Notably: line endings must be CRLF, and the strings must be null-terminated. We convert from LF **to** CRLF endings when pasting on Windows, but we don't do any conversion in the other direction (CRLF copied on a remote desktop will be sent directly to the user's workstation unmodified).
zmb3
force-pushed
the
zmb3/clipboard-null-terminate
branch
from
4e3e99e to
b68c556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably: line endings must be CRLF, and the strings must be
null-terminated.
We convert from LF to CRLF endings when pasting on Windows, but we don't
do any conversion in the other direction (CRLF copied on a remote
desktop will be sent directly to the user's workstation unmodified).
Updates #9980