Skip to content

lint: Fix linter warning, fix typo #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescowens merged 2 commits into from
Aug 16, 2021
Merged

lint: Fix linter warning, fix typo #2276

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6d17f5
Fix linter warning, fix typo
barton2526 Aug 13, 2021
41292bb
Exclude rpcstresstest script from shellcheck
barton2526 Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion share/qt/extract_strings_qt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def parse_po(text):

messages = parse_po(out.decode('utf-8'))

f = open(OUT_CPP, 'w')
f = open(OUT_CPP, 'w', encoding="utf-8")
f.write("""

#include <QtGlobal>
Expand Down
2 changes: 1 addition & 1 deletion src/qt/sendcoinsdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ void SendCoinsDialog::selectedConsolidationRecipient(SendCoinsRecipient consolid
}

// The AddressTableModel substitutes the translated "(no label)" when the label is empty. If we use
// that here, we will end up pasting a literal lable of "(no label)". Because the translation (tr) should
// that here, we will end up pasting a literal label of "(no label)". Because the translation (tr) should
// be consistent between here and the AddressTableModel::data, it should match the conditional and be put
// back to the desired empty QString.
if (consolidationRecipient.label == tr("(no label)")) consolidationRecipient.label = QString();
Expand Down