refactor, misc: remove CBitcoin(Address|Secret) #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Taking the plunge on this one, eh? :) |
Member
Author
|
Just needs key_io tests and testing now. |
div72
force-pushed
the
cleanup-key-io
branch
3 times, most recently
from
383162e to
a56ec05
Compare
jamescowens
added
compatibility
deprecation
div72
changed the title
div72
force-pushed
the
cleanup-key-io
branch
4 times, most recently
from
6664c70 to
17f4049
Compare
div72
changed the title
Rationale:
With the recent move to libsecp256k1, most of the key managament
code was refactored. This commit follows up on that by cleaning
up the usages of CSecret for the removal of CBitcoinSecret
altogether.
Mostly based on upstream commit
bitcoin/bitcoin@dfa23b9.
Rationale:
This RPC method is a relic of past that's better replaced
by the dumpwallet/importwallet combo. This commit removes
them for the CBitcoinSecret removal.
Rationale:
This commit replaces the usages of CBitcoinSecret with
new utility methods. This moves base58.h/cpp towards more of a
pure utility and moves us closer to upstream.
Loosely based on
bitcoin/bitcoin@32e69fa.
Rationale:
With the recent libsecp256k1 port, most of the key code has been
moved much close to upstream. This commit is the last step on also
moving key IO code closer to the upstream. This changes also enable
us to use bech32 addresses without much hassle.
The changes were also loosely done to drop the CBase58Data class
which was not chain agnostic in order to support other chains. (Like
regtest.)
The second element of items of key_io_valid JSON array was pkhash or scripthash. This commit changes them to be proper serialized scripts as thats what the key_io_valid expects. isTestNet flags are also changed to a chain string.
Rationale:
Sadly some other tests depends on the chain being mainnet without actually
setting it to mainnet themselves. Which leads to weird test suite
failures.
Member
Author
|
@jamescowens This is ready for a review as well. |
Member
|
Tested alerting on testnet (sendalert2). |
jamescowens
added a commit
that referenced
this pull request
Feb 16, 2025
Added - depends: add cross arm64-darwin support #2775 (@div72) - build: add missing randomness checks #2772 (@div72) - init, registry: Support -clearallregistryhistory startup parameter #2773 (@jamescowens) Changed - build: omit _FORTIFY_SOURCE on debug #2793 (@div72) - doc: cmake is required for Windows depends #2791 (@barton2526) - CMake: Set maximum supported Boost version #2788 (@CyberTailor) - ci: bump to MacOS 13 #2784 (@div72) - build/cmake: disable LevelDB tests #2776 (@div72) - util: use XDG_STATE_HOME for datadir on Flatpak #2774 (@div72) - util, build: Support miniupnp API version 18+ #2771 (@jamescowens) - build: explicitly include FindPkgConfig for CMake #2769 (@jamescowens) - ci, cd: bump action versions #2763 (@div72) - Sync CMake CI #2762 (@CyberTailor) - cpid: Modify CPID local hasher to eliminate compiler warnings on 32 bit archs #2760 (@jamescowens) Removed - refactor, misc: remove CBitcoin(Address|Secret) #2634 (@div72) Fixed - poll, gui: Disable choice add button in poll wizard when choice limit is reached #2792 (@jamescowens) - diagnose, rpc: fix compilation with boost 1.87 #2786 (@div72) - node: fix build with GCC 15 #2783 (@CyberTailor) - ci: use overwrite with brew install on MacOS CMake #2782 (@div72) - scraper: Protect access to ConvergedStats.csv.gz with a lock #2779 (@jamescowens) - fix build on FreeBSD #2770 (@wilkart) - rpc/server: fix removing deprecated commands from command list #2768 (@lrusak) - cmake bdb53: disable error for implicit-int with gcc #2767 (@lrusak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing checklist:
(Testing checklist copied from the libsecp256k1 port PR.)