build: CMake: Initial Windows support (MSYS2) #2733
Conversation
|
I just merged #2734. You probably need to rebase this on the development branch again. |
This starts a series of commits introducing Hunter Package Manager support. The end goal is to make building with CMake on Windows possible.
There are lots of build failures using it. Pulling newer Bitcoin code should help.
Enabled by default on Windows.
Enabled by default on Windows.
|
@CyberTailor Why hunter, instead of (for example) conan? P.S. MacOS CI failure is unrelated, seems like a GH issue. |
I'm not familiar with Conan and don't know any projects that use it with CMake. |
|
(sorry for confusion, i've mistook browser tabs) |
|
@CyberTailor can we get this into Miss Piggy or should I push to Natasha? |
|
I think yes. It'd be hard to continue without feedback |
|
I did take a peek at this PR, nothing popped out to me but I haven't used CMake before and I'm not a Windows user so I don't really think I'm qualified to give a proper review. There does seem to be something weird on how defines are processed (also on MacOS) but it seems to compile and run ok. Since automake is currently our sanctioned build system, it shouldn't matter if this lands in Miss Piggy or Natasha imo as long as there are no code changes. |
|
I am not qualified to review it either. If it seems to compile and run ok, lets go ahead and merge it. |
Added - build: add option for sanitizers gridcoin-community#2553 (@div72) - build: CMake: Initial Windows support (MSYS2) gridcoin-community#2733 (@CyberTailor) Changed - build: enforce SSE2 on x86 targets gridcoin-community#2746 (@div72) - consensus: Update checkpoint data for mainnet and testnet gridcoin-community#2756 (@jamescowens) - gui, util: Enhance verify checkpoints fail handling; use RegistryBookmarks for DB passivation gridcoin-community#2758 (@jamescowens) Removed Fixed - build, depends: fix compilation with XCode 15 gridcoin-community#2747 (@div72) - Fix man page installation path for cmake builds gridcoin-community#2749 (@theMarix) - consensus, mrc, sidestake: add mrc fees to staker to rewards to be allocated via sidestaking gridcoin-community#2753 (@jamescowens) - Fix Systemd unit install location gridcoin-community#2754 (@theMarix) - scraper: Corrections to scraper_net after removal of cntPartsRcvd decrement and increment gridcoin-community#2755 (@jamescowens) - rpc: fix setban segfault gridcoin-community#2757 (@div72)
3 participants
This PR is a follow-up to #2676. The following changes make it possible to build Gridcoin with CMake in Windows.
It also adds the Hunter dependency manager for systems without package management abilities.
TODO for next pull requests: