scraper: Change scraper_net unserialize check to include ALL_BUT_DELETED projects #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts. This should fix a validation error that is occurring on testnet post mandatory.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the scraper network to include greylisted projects (all but deleted) when determining the maximum number of projects to be processed in a manifest.
- Changes the snapshot filter from the default active projects to include all projects except deleted ones.
- Updates the computation of nMaxProjects to use the new snapshot size.
Comments suppressed due to low confidence (1)
src/gridcoin/scraper/scraper_net.cpp:511
- Consider adding tests to verify that using the ALL_BUT_DELETED filter correctly includes greylisted projects, ensuring the change behaves as expected in different scenarios.
std::ceil(static_cast<double>(GRC::GetWhitelist().Snapshot(GRC::ProjectEntry::ProjectFilterFlag::ALL_BUT_DELETED).size()) /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a validation error that is occurring on testnet post mandatory. The implementation of autogreylisting means that the greylisted projects should be included in the whitelist project list used for the determination of max projects in a manifest, rather than just the active projects (which is the default).