gui, init: Fixes the 'Blocks Verified' message total #2814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct total This also fixes an off by one error where 1001 block would be checked rather than 1000, for example
Member
|
Yep. I had noticed this a long time ago, but never got around to fixing it. Glad you took a whack at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the '1000/1000 Blocks Verified' message which previously would show an incorrect denominator.
Previously the total was the total block height, whereas now it is the number of blocks to be verified. The numerator in the message was also often set to 1000 prematurely as this occurred after reaching a block with height divisible by 1000, even if this is the first block.
This also fixes an off-by-one error where 1001 block would be verified rather than 1000, which is the expected default.
Note that the documentation lists this for the -checkblocks= argument
"How many blocks to check at startup (default: 2500, 0 = all)"
but this does not seem to be accurate as 0 isn't handled and the default is 1000.
This is not handled in this PR