bdb53: Update embedded bdb53 code for gcc15+ #2816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps the functors in env_config.c with pointer casts to allow compilation in the stricter gcc15+. Note there is a lot of remaining technical debt in bdb53, including old K&R style function definitions that are throwing warnings and will eventually be a problem. For right now, this will suffice.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the env_config.c functor entries to compile under GCC 15+ by wrapping each function pointer in an int (*)(void) cast.
- Added explicit
(int (*)(void))casts around existing configuration functions to satisfy stricter pointer-type checks in GCC 15+. - No changes to underlying logic; purely a compilation workaround.
- Leaves existing K&R-style definitions and other technical debt for future cleanup.
Comments suppressed due to low confidence (1)
src/bdb53/src/env/env_config.c:93
- [nitpick] This entry’s spacing is inconsistent with others (missing space after comma). Align commas and indentation to match the surrounding entries for readability.
{ "set_intermediate_dir_mode",CFG_STRING, (int (*)(void))__env_set_intermediate_dir_mode },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the functors in env_config.c with pointer casts to allow compilation in the stricter gcc15+. Note there is a lot of remaining technical debt in bdb53, including old K&R style function definitions that are throwing warnings and will eventually be a problem. For right now, this will suffice, and should fix the problems with Arch and other distributions that are using the gcc15 compiler.