Data race fixes #866
Merged
Data race fixes #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only done on initialization and is a quick operation. By removing the thread the rest of the implementation gets simplified.
It was possible for the used data structures to be modified by the block acceptor thread while used by the stake thread. This could result in a crash, see gridcoin-community#865.
tomasbrod
approved these changes
Jan 23, 2018
Member
|
Running this PR and it passed right thru the 120 block. No crash when syncing, nor running. It may just been luck. -> #868 |
denravonska
added a commit
that referenced
this pull request
Jan 24, 2018
Fixed: - Fix crash when switching to new tally on block 1144120, #868 (@denravonska). - Fix crash when staking while tallying, #866 (@denravonska).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the CPID thread and extend the cs_main lock in the miner.