Skip to content

create voltage level topology first try #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

EtienneLt
Copy link
Contributor

No description provided.

@EtienneLt EtienneLt self-assigned this Jun 11, 2025
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
@ghazwarhili
Copy link
Contributor

  1. TS2741: Property sectionOptions is missing in type

  2. TS2322: Type
    ObjectSchema<{
    sectionCount: number | null | undefined;
    switchesBetweenSections: string | null | undefined;
    }, AnyObject, {
    sectionCount: undefined;
    switchesBetweenSections: undefined;
    }, "">
    is not assignable to type

=> typing issues to be resolved

@@ -11,7 +11,7 @@
"dependencies": {
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.0",
"@gridsuite/commons-ui": "0.107.1",
"@gridsuite/commons-ui": "file:../commons-ui/gridsuite-commons-ui-0.107.1.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

"resolved": "https://registry.npmjs.org/@gridsuite/commons-ui/-/commons-ui-0.107.1.tgz",
"integrity": "sha512-i72NeOKiu+Kj4dmze9LPH1PAeP/ff3X8qqDEuA1X0fXCtW5slFhf1qTJUxK5X8H1Jq0FBgWA2ptmf5x1JXAiYw==",
"resolved": "file:../commons-ui/gridsuite-commons-ui-0.107.1.tgz",
"integrity": "sha512-nCKEIr1kCRKWY2hHXY5+y3IWEJEaVF60kPVWXa4MAAxKo75uEdNN6AAR6dpZixqHS5FDixMQfm+Ng6TDwq+pog==",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

package.json Outdated
@@ -11,7 +11,7 @@
"dependencies": {
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.14.0",
"@gridsuite/commons-ui": "0.107.1",
"@gridsuite/commons-ui": "file:../commons-ui/gridsuite-commons-ui-0.107.1.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

currentNode,
currentRootNetworkUuid,
}: Readonly<CreateVoltageLevelTopologyFormProps>) {
const [isDiagramPaneOpen, setIsDiagramPaneOpen] = useState(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated code fragment (see CreateCouplingDeviceForm)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I harmonize that ?

import { SwitchesBetweenSections } from "../voltage-level/switches-between-sections/switches-between-sections";

export interface CreateVoltageLevelTopologyFormProps {
sectionOptions: Option[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants