add field description to modification #3546
Open
+120
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
EtienneLt
reviewed
Dec 11, 2025
| const rootNetworks = useSelector((state: AppState) => state.rootNetworks); | ||
| const isMonoRootStudy = useSelector((state: AppState) => state.isMonoRootStudy); | ||
| const highlightedModificationUuid = useSelector((state: AppState) => state.highlightedModificationUuid); | ||
| const [hoveredRowIndex, setHoveredRowIndex] = useState<number>(); |
Contributor
There was a problem hiding this comment.
no initial value for this state ?
Contributor
There was a problem hiding this comment.
and no need to precise type if there is a default value
Contributor
Author
There was a problem hiding this comment.
Actually when I precised -1 as a default value, the hovered index was lost when the page rerendered. It is surprising because according to react help it shouldn't. I don't have the explanation.
EtienneLt
reviewed
Dec 11, 2025
src/components/graph/menus/network-modifications/DescriptionRenderer.tsx
Outdated
Show resolved
Hide resolved
EtienneLt
reviewed
Dec 11, 2025
src/components/graph/menus/network-modifications/DescriptionRenderer.tsx
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Dec 12, 2025
| import { setModificationDescription } from '../../../../services/study/network-modifications'; | ||
|
|
||
| export interface DescriptionRendererProps extends ICellRendererParams<NetworkModificationMetadata> { | ||
| setModifications: React.Dispatch<SetStateAction<NetworkModificationMetadata[]>>; |
Contributor
There was a problem hiding this comment.
Don't import the whole react dependency, but just dispatch like it's done for set state action.
Contributor
Author
There was a problem hiding this comment.
Actually you made me realise that I don't need that prop anymore. Removed : 1dcc6d6
Contributor
There was a problem hiding this comment.
Okay, but you still import React
src/components/graph/menus/network-modifications/DescriptionRenderer.tsx
Outdated
Show resolved
Hide resolved
src/components/graph/menus/network-modifications/DescriptionRenderer.tsx
Outdated
Show resolved
Hide resolved
src/components/graph/menus/network-modifications/network-modifications-table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
EtienneLt
changed the title
flomillot
reviewed
Dec 16, 2025
| */ | ||
| import { ICellRendererParams } from 'ag-grid-community'; | ||
| import { DescriptionModificationDialog, EditNoteIcon, NetworkModificationMetadata } from '@gridsuite/commons-ui'; | ||
| import React, { useCallback, useState } from 'react'; |
Contributor
There was a problem hiding this comment.
You still have a global react import
| import { setModificationDescription } from '../../../../services/study/network-modifications'; | ||
|
|
||
| export interface DescriptionRendererProps extends ICellRendererParams<NetworkModificationMetadata> { | ||
| setModifications: React.Dispatch<SetStateAction<NetworkModificationMetadata[]>>; |
Contributor
There was a problem hiding this comment.
Okay, but you still import React
src/components/graph/menus/network-modifications/DescriptionRenderer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
|
flomillot
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
allows to add a description to individual netmods in the tree view using : gridsuite/commons-ui#955
moves NetworkModificationMetadata to commons-ui